https://bugzilla.redhat.com/show_bug.cgi?id=1278293
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
Some style *suggestions*:
pushd %{buildroot}%{_bindir}
for mod in recon_status recon_movie check_mni_reg recon_process_stats
ts_movie
do
sed -i '1s|^#!.*$|#!%{__python3}|' $mod
done
# Depends on 'freeview' utility
rm -f {recon,warp}_qc
popd
can be written as
rm %{buildroot}%{_bindir}/{recon,warp}_qc
sed -i '1s|^#!.*$|#!%{__python3}|' %{buildroot}%{_bindir}/*
# Disable one of tests for now due to:
https://github.com/mwaskom/moss/issues/17
sed -i -e '/def test_remove_by_group(self):/a \ \ \ \ \ \ \ \ from
nose.plugins.skip import SkipTest; raise
SkipTest("https://github.com/mwaskom/moss/issues/17";)'
moss/tests/test_statistical.py
can be written as
nosetests-%{python2_version} -v -x test_remove_by_group || :
nosetests-%{python3_version} -v -x test_remove_by_group || :
- license is OK
- license file is present and %license is used
- build follows new python guidelines
- requirements and provides are sane
- rpmlint has nothing interesting to say:
python2-moss.noarch: E: explicit-lib-dependency python-matplotlib
python2-moss.noarch: W: spelling-error Summary(en_US) neuroimaging ->
micromanaging
python2-moss.noarch: W: spelling-error %description -l en_US neuroimaging ->
micromanaging
python3-moss.noarch: E: explicit-lib-dependency python3-matplotlib
python3-moss.noarch: W: spelling-error Summary(en_US) neuroimaging ->
micromanaging
python3-moss.noarch: W: spelling-error %description -l en_US neuroimaging ->
micromanaging
python3-moss.noarch: W: python-bytecode-without-source
/usr/lib/python3.5/site-packages/moss/__pycache__/leastsqbound.cpython-35.opt-1.pyc
...
python3-moss.noarch: W: no-manual-page-for-binary check_mni_reg
python3-moss.noarch: W: no-manual-page-for-binary recon_status
python3-moss.noarch: W: no-manual-page-for-binary ts_movie
python3-moss.noarch: W: no-manual-page-for-binary recon_movie
python3-moss.noarch: W: no-manual-page-for-binary recon_process_stats
python-moss.src: W: spelling-error Summary(en_US) neuroimaging -> micromanaging
python-moss.src: W: spelling-error %description -l en_US neuroimaging ->
micromanaging
3 packages and 0 specfiles checked; 2 errors, 27 warnings.
Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
