https://bugzilla.redhat.com/show_bug.cgi?id=1283296

Zbigniew JÄ™drzejewski-Szmek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #5 from Zbigniew JÄ™drzejewski-Szmek <[email protected]> ---
find -exec rm -f {} ';' can be replaced with find -delete.

It is nice to put BuildRequires/Requires each on a separate line.

%description should end in a dot.

The module should not Require pam: it is a plugin for pam. It already has an
automatically generated dependency on libpam.so, and that is enough. Other pam
modules do not Require pam.

Where can the environment variable DEFAULT_AUTHFILE_DIR_VAR come from?

I didn't look at pamu2fcfg, but the code of the pam module appears to be
carefully written, looks correct.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to