https://bugzilla.redhat.com/show_bug.cgi?id=1265685
Ralf Corsepius <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #5 from Ralf Corsepius <[email protected]> --- Ranjan, your "rant" on users@ has provoked me enough to add some informal comments on this package (based on *0.8-1 from comment#1): * *.spec is cluttered with rpm anachronisms, which should not be used in new *.spec: - Remove %clean - Remove "rm -rf $RPM_BUILD_ROOT" from %install - Remove BuildRoot - Remove %defattr * Packages should not be installed using %makeinstall, but be using DESTDIR, e.g. use %make_install instead. * Package wastes resources on building a static library. - Append --disable-static to %configure - Remove "rm ..../*.a" * AFAIS, this package seems to bundle a library (libsylpheed) which already is in Fedora (package sylpheed). You should be using the unbundled version. (%configure --with-libsylph=sylpheed --with-libsylph-dir=/usr) * COPYING is duplicated in %doc and %license. Remove the copy from %doc. * The package should be split into a *-devel and non-devel subpackages. (In reply to Ranjan Maitra from comment #3) > Updated spec and SRPM files are here: > > SPEC: http://maitra.public.iastate.edu/Fedora/sylfilter.spec > SRPM: http://maitra.public.iastate.edu/Fedora/sylfilter-0.8-1.fc23.src.rpm Increment the %release each time you change something in your *spec. Not incrementing Release avoidably complicates reviews. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
