https://bugzilla.redhat.com/show_bug.cgi?id=1287120

Haïkel Guémar <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
              Flags|                            |fedora-review?



--- Comment #4 from Haïkel Guémar <[email protected]> ---
Few comments:
* typo in the download url
https://pypi.python.org/packages/source/r/ryu/ryu-3.26.tar.gz
* I'd remove *requirements files to prevent pbr downloading stuff
https://github.com/openstack-packages/keystone/blob/rpm-master/openstack-keystone.spec#L135
* removing %{pypi_name}.egg-info in %prep
* build in Koji fails due to pbr trying to access network, note that
koji/cbs/brew uses local repositories and have no network access.
(see, my scratch build above)
* quick grep shows missing requirement to six.

But it's in good shape, no licensing issues

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to