https://bugzilla.redhat.com/show_bug.cgi?id=1273693
--- Comment #3 from Andrew Stiegmann <[email protected]> --- > This would be useful for my work so I'm happy to do the review. Hooray... finally a reviewer! Thanks for the time. > Note I'm not a sponsor but following FESCO ticket 1499[1] I can carry out the > review and once approved you can file a ticket at the sponsorship trac > instance[2] indicating you need a sponsor for a package that has completed > review. Not ideal but its something. I'll take it. > My initial pre-fedora-review comments: > > * Remove all that commented blurb at the top of the spec > * Group is not required and shouldn't be used in current fedora specs > * Use %autosetup macro rather than separate %setup then %patch macros > * You are referencing %srcname which is not defined > > I'll add the more complete formal review within the next few days to add to > the initial comments. Got it. I'll apply this feedback as well as upgrade to the latest package and submit another build to koji. I'll post back here when its ready. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
