https://bugzilla.redhat.com/show_bug.cgi?id=1290995

Zbigniew JÄ™drzejewski-Szmek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review+



--- Comment #1 from Zbigniew JÄ™drzejewski-Szmek <[email protected]> ---
+ license is OK (BSD)
+ license file is missing, but the only source file has a prominent license
header
+ latest version (upstream is semi-dead, but I think it doesn't really mean
much for scientific software)
+ new python packaging template is used
+ provides/requires are OK
+ builds and install OK
+ no scriptlets
+ fedora review is happy

Rpmlint
-------
Checking: python2-visionegg-quest-1.1-1.fc24.noarch.rpm
          python3-visionegg-quest-1.1-1.fc24.noarch.rpm
          python-visionegg-quest-1.1-1.fc24.src.rpm
python2-visionegg-quest.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/Quest.py 644 /usr/bin/env
python3-visionegg-quest.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/Quest.py 644 /usr/bin/env
I guess you could fix that.

python2-visionegg-quest.noarch: W: no-documentation
python3-visionegg-quest.noarch: W: no-documentation
python3-visionegg-quest.noarch: W: python-bytecode-without-source
/usr/lib/python3.5/site-packages/__pycache__/Quest.cpython-35.opt-1.pyc
3 packages and 0 specfiles checked; 2 errors, 3 warnings.

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to