https://bugzilla.redhat.com/show_bug.cgi?id=1286772
Javier Peña <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] --- Comment #6 from Javier Peña <[email protected]> --- Hello Chandar, I have found a few issues in the current spec: - the -tests subpackage (python-magnumclient-tests) needs to depend on the same version-release of the main subpackage (python-magnumclient = %{version}-%{release}). - Binary /usr/bin/magnum is present on both the python2 and python3 subpackages, and in the python2 subpackage it requires python3 to be present. This is not correct according to https://fedoraproject.org/wiki/Packaging:Python#Executables_in_.2Fusr.2Fbin . You may want to follow the same concept as http://pkgs.fedoraproject.org/cgit/python-reno.git/tree/python-reno.spec to fix this (although it is a bit convoluted, right now I don't know of a better way to do it). - Removing the egg-info in %prep should not be done (https://fedoraproject.org/wiki/Packaging:Python_Eggs#Providing_Egg_Metadata_Using_Setuptools). rpmlint complains about the magnum binary not having a man page. I'm not sure if it can be generated using sphinx, do you know? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
