https://bugzilla.redhat.com/show_bug.cgi?id=1234210
Zbigniew Jędrzejewski-Szmek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks|177841 (FE-NEEDSPONSOR) | Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #33 from Zbigniew Jędrzejewski-Szmek <[email protected]> --- Let's finish the review. It's 95% of the way there ;) While this review has been in progress, python packaging guidelines have changed (See https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file). You should change %build and %install to %build %py2_build %install py2_install This should have the exact same effect, but is standard and more concise. %description is still awkward. If you really want to keep the history part in, at least remove the paragraph about PDFtk. No need to go into detail about an alternative project's downsides. Please add empty lines between each entry in %changelog. -- I recently gained the sponsorship privileges and I'd be happy to sponsor you into the packagers group. Please open up a fresh copy of https://fedoraproject.org/wiki/Packaging:Guidelines, fire up fedora-review, and do a two-three reviews from https://fedoraproject.org/PackageReviewStatus/NEW.html, and paste the links here. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
