https://bugzilla.redhat.com/show_bug.cgi?id=1279112

Dmitry Mikhirev <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Dmitry Mikhirev <[email protected]> ---
An informal review.

* The correct version number should be 1.3.0, not 130 (according to folder
names at http://sourceforge.net/projects/kissfft/files/kissfft/).
* As the complete library name is "Kiss FFT" and upstream source archive is
named kiss_fft, probably the more correct name for package should be delimited,
kiss-fft.
* Building only static libraries seems reasonable.

rpmlint output:

Checking: kissfft-devel-130-1.fc23.x86_64.rpm
          kissfft-130-1.fc23.src.rpm
kissfft-devel.x86_64: W: spelling-error %description -l en_US radix -> radii,
radio, rad ix
kissfft.src: W: spelling-error %description -l en_US radix -> radii, radio, rad
ix
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Everything is OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to