https://bugzilla.redhat.com/show_bug.cgi?id=1229886
Jeremy Cline <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #6 from Jeremy Cline <[email protected]> --- Hi William. Currently, this package will not build, so I'll just do a brief review and do a full review once it builds: 1. The BuildRequires dependency on 'python3-sphinx' is, unfortunately, not enough. The '/usr/bin/sphinx-build' binary is provided by 'python-sphinx' (the Python 2 version of the package). The 'python3-sphinx' package provides '/usr/bin/sphinx-build-3', so you can either alter the Makefile that builds the documentation, or depend on 'python-sphinx' instead. 2. Your %build and %install sections can use %py3_build and %py3_install 3. You should not manually compress the man pages, as they are compressed automatically by the build system (https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages). 4. Just so you know, you can use the '-D' flag with 'install' rather than calling 'mkdir -p' before 'install'. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
