https://bugzilla.redhat.com/show_bug.cgi?id=1295144
--- Comment #7 from gil cattaneo <[email protected]> --- (In reply to Martin Ueding from comment #4) > Hi Gil, > > thank you for the constructive feedback! > > - I changed the `Release` to include the leading zero. this is not a pre-release than you should use %global commit0 1e158fb %global shortcommit0 %(c=%{commit0}; echo ${c:0:11}) Name: xss-lock Release: 1%{?dist} Source0: https://bitbucket.org/raymonad/%{name}/get/%{commit0}.tar.gz#/%{name}-%{shortcommit0}.tar.gz %changelog * Sat Jan 02 2016 Martin Ueding <[email protected]> 0.3.0-1 - initial rpm https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags > - Regarding the `%license` I am not so sure what I should exactly do with it. > Is it correct to add this to the `%files` section as I did? yes, well done Please, remove: %define checkout 20140302git or use (i don't understand what it is needed, for me should better use the above example) %global checkout 20140302git https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
