https://bugzilla.redhat.com/show_bug.cgi?id=1293045

Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
       Docs Contact|zbys...@in.waw.pl           |
           Assignee|nob...@fedoraproject.org    |zbys...@in.waw.pl
              Flags|                            |fedora-review+



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
+ license is OK (GPLv3+)
+ license file is present, %license is used
+ latest version
+ builds and install OK
+ scriptlets match guidelines
+ standard macros are used

You could %exlude %{_pkgdocdir}/COPYING to avoid duplicated file (and a warning
from rpmlint).

Unfortunately you violate one significant guideline: the package uses stuff
packaged as %doc at runtime. When installed with --exludedocs, internal help is
missing and other things are broken too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to