https://bugzilla.redhat.com/show_bug.cgi?id=1259486
Zbigniew Jędrzejewski-Szmek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #5 from Zbigniew Jędrzejewski-Szmek <[email protected]> --- Why not use a tarball directly from github, and run autogen.sh during %build? In general it is a good idea to regenerate everything from pristine sources, and in this case it will avoid the need for manual steps and simplify maintenance and allow automatic version bumps. [1] in the %description doesn't point anywhere. %description should end in a dot. make %{?_smp_mflags} V=1 → %make_build V=1 find %{buildroot} -name '*.la' -exec rm -f {} ';' → find %{buildroot} -name '*.la' -delete (-f is bad, because it means "ignore errors", and if an error happened here, you actually want the build to fail. Anyway -delete is nicer.) No %license file? No %check? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
