https://bugzilla.redhat.com/show_bug.cgi?id=1299558



--- Comment #1 from Robert Kuska <[email protected]> ---
The check phase in specfile is redudant, no tests are run nor present in
package.

"Ran 0 tests in 0.000s"

It's probably better to use %{version} macro in Source0 so you don't have to
edit the link everytime you update the package. 

Also you've defined %{sum} macro and used it only in main package description
even though both subpackages could use it as well in their description.


These are just minor issues and otherwise it looks nice! :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to