https://bugzilla.redhat.com/show_bug.cgi?id=1300003
Brandon Thomas <bthoma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bthoma...@gmail.com
--- Comment #3 from Brandon Thomas <bthoma...@gmail.com> ---
This is an unofficial review, and will not effect the status of this review
request.
* I believe the spec file should be named fleet-commander-admin.spec, since
fleet-commander only exists as two separate projects (fleet-commander-client
and fleet-commander-admin).
* As a corollary to that, since the package "fleet-commander" does not exist,
the subpackage fleet-commander-admin should be the main packages name.
* You probably want more information in your summaries and descriptions, since
a user probably doesn't know what fleet commander is.
* You should probably use "%make_build" over "make".
* It is not necessary to have a "%clean" section.
* Including fonts should be avoided. I'm not sure if this is because of some
technical restriction, but if possible, you should use the fonts provided in
Fedora.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
