https://bugzilla.redhat.com/show_bug.cgi?id=1298715

Zbigniew Jędrzejewski-Szmek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #10 from Zbigniew Jędrzejewski-Szmek <[email protected]> ---
The package name is OK, the license is OK, %license is used, package has the
latest version, builds and installs OK. Packaging matches all guidelines.

If there are problems, it's because there are no guidelines and this package is
doing something new. So there might be bugs, let's see how this goes. Package
is APPROVED.

I see one small issue (and it's in the code I suggested ;)):
globs expansion should be prevented. Please change %preun, %postun to put the
argument in quotes (%{name}@*.service → '%{name}@*.service').

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to