https://bugzilla.redhat.com/show_bug.cgi?id=1301253



--- Comment #2 from Austin Dunn <[email protected]> ---
(In reply to Brandon Thomas from comment #1)

Thanks for the review!

> * I don't believe that Amusements/Games" is a valid group.
Amusements/Games is a valid group. Try "cat /usr/share/doc/rpm/GROUPS"

> * "make %{?_smp_mflags}" can be replaced with "%make_build".
That was in the vim .spec template, I will fix it in an update.

> * You probably want the install and ln command to be in the "%install"
See above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to