https://bugzilla.redhat.com/show_bug.cgi?id=1282903
--- Comment #12 from Jan Chaloupka <[email protected]> --- Makefile contains 'go get' command: go get github.com/cpuguy83/go-md2man It is against packaging policies. It must by patched in the package. The project is already built in the distribution as golang-github-cpuguy83-go-md2man package. It provides go-md2man binary, so "Requires: go-md2man" will install the package. At the same time if you use Makefile - the package can not be built with debug info support - the package can be built only for architectures with golang compiler, no with gcc-go unless you patch the Makefile. Would recommend to move content of Makefile into the spec instead of running make. However, not blocker for the review. If possible, create Godeps.json file for the project with commit of github.com/godbus/dbus used. I.e. { "ImportPath": "github.com/coreos/etcd", "GoVersion": "go1.5.1", "Packages": [ "./..." ], "Deps": [ { "ImportPath": "github.com/godbus/dbus", "Rev": "COMMIT" } ] } so we can validate the dependency is provided by the distribution and up-to-date. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
