https://bugzilla.redhat.com/show_bug.cgi?id=1301589
--- Comment #8 from gil cattaneo <[email protected]> --- (In reply to Pavel Alexeev from comment #7) > I have tested on Fedora 23. Directory owning should be addressed here then. > > > [!]: Fully versioned dependency in subpackages if applicable. > > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > > super-csv- > > benchmark, super-csv-dozer, super-csv-java8, super-csv-joda, > > super-csv-parent, > > super-csv-javadoc > > No, it does not happened. Please look at review requires above. > And it easy to check, f.e. super-csv-benchmark easy installed without > super-csv: > $ rpm -qa 'super-csv*' > [empty] > $ sudo rpm -Uh super-csv-benchmark-2.4.0-1.fc22.noarch.rpm > $ rpm -qa 'super-csv*' > super-csv-benchmark-2.4.0-1.fc22.noarch As wrote above "Requires are handled by our Java tools" and i do not see a reason to explicit. "super-csv" JAR is used only as test deps, nothing more And you should rub fedora-review for f23 or major > > These a maven build style and %check section is unnecessary > Yes. It should, not must item: > https://fedoraproject.org/wiki/Packaging:Guidelines#Test_Suites > But strongly recommended if upstream include tests. Test Suite is already running in the build section. You should see the documentation that I mentioned above, it is one of the few exceptions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
