https://bugzilla.redhat.com/show_bug.cgi?id=1189015
--- Comment #18 from Antonio Trande <anto.tra...@gmail.com> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions - doc/sphinx/source/logos is released under CC-BY-ND license. I guess -doc subpackage must contain an own License tag: License: CC-BY-ND and GPLv2+ - -doc subpackage does not provide its own doc files (LICENSE AUTHORS CHANGELOG README SUMMARY.txt) - The libxdr code for accessing Gromacs trajectories including our modifications is published under the Lesser GNU Public Licence (LGPL). LGPLv2 license is missing. - Package does not provide python2-MDAnalysis (see Provides list) Since, sooner or later, this software will support Python3, I think it's better to package a python2-MDAnalysis already now. http://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file - python_provide macro is missing - Please, fix non-standard-executable-perm and unused-direct-shlib-dependency errors (see rpmlint output) ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "GPL (v2 or later)", "Unknown or generated". 261 files have unknown license. Detailed output of licensecheck in /home/sagitter/FedoraReview/1189015-python-MDAnalysis/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 71680 bytes in 4 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- MDAnalysis-doc , python-MDAnalysis-debuginfo [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-MDAnalysis-0.13.0-2.fc24.x86_64.rpm python-MDAnalysis-doc-0.13.0-2.fc24.noarch.rpm python-MDAnalysis-debuginfo-0.13.0-2.fc24.x86_64.rpm python-MDAnalysis-0.13.0-2.fc24.src.rpm python-MDAnalysis.x86_64: E: explicit-lib-dependency python-matplotlib python-MDAnalysis.x86_64: W: spelling-error %description -l en_US isGPL -> Ispell python-MDAnalysis.x86_64: W: spelling-error %description -l en_US dcd -> dc, dd, did python-MDAnalysis.x86_64: W: spelling-error %description -l en_US Gromacs -> Groomsman python-MDAnalysis.x86_64: W: spelling-error %description -l en_US libxdrfile -> fiberfill python-MDAnalysis.x86_64: W: no-soname /usr/lib64/python2.7/site-packages/MDAnalysis/lib/c_distances_openmp.so python-MDAnalysis.x86_64: W: no-soname /usr/lib64/python2.7/site-packages/MDAnalysis/lib/qcprot.so python-MDAnalysis.x86_64: W: no-soname /usr/lib64/python2.7/site-packages/MDAnalysis/lib/c_distances.so python-MDAnalysis.x86_64: W: no-soname /usr/lib64/python2.7/site-packages/MDAnalysis/lib/_transformations.so python-MDAnalysis.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/MDAnalysis/lib/c_distances_openmp.so 775 python-MDAnalysis.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/MDAnalysis/lib/qcprot.so 775 python-MDAnalysis.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/MDAnalysis/lib/c_distances.so 775 python-MDAnalysis.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/MDAnalysis/coordinates/_dcdmodule.so 775 python-MDAnalysis.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/MDAnalysis/coordinates/xdrfile/_libxdrfile2.so 775 python-MDAnalysis.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/MDAnalysis/lib/_transformations.so 775 python-MDAnalysis.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/MDAnalysis/coordinates/dcdtimeseries.so 775 python-MDAnalysis.src: W: spelling-error %description -l en_US isGPL -> Ispell python-MDAnalysis.src: W: spelling-error %description -l en_US dcd -> dc, dd, did python-MDAnalysis.src: W: spelling-error %description -l en_US Gromacs -> Groomsman python-MDAnalysis.src: W: spelling-error %description -l en_US libxdrfile -> fiberfill 4 packages and 0 specfiles checked; 8 errors, 12 warnings. Rpmlint (debuginfo) ------------------- Checking: python-MDAnalysis-debuginfo-0.13.0-2.fc24.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- python-MDAnalysis.x86_64: E: explicit-lib-dependency python-matplotlib python-MDAnalysis.x86_64: W: spelling-error %description -l en_US isGPL -> Ispell python-MDAnalysis.x86_64: W: spelling-error %description -l en_US dcd -> dc, dd, did python-MDAnalysis.x86_64: W: spelling-error %description -l en_US Gromacs -> Groomsman python-MDAnalysis.x86_64: W: spelling-error %description -l en_US libxdrfile -> fiberfill python-MDAnalysis.x86_64: W: no-soname /usr/lib64/python2.7/site-packages/MDAnalysis/lib/_transformations.so python-MDAnalysis.x86_64: W: unused-direct-shlib-dependency /usr/lib64/python2.7/site-packages/MDAnalysis/lib/_transformations.so /lib64/libpthread.so.0 python-MDAnalysis.x86_64: W: no-soname /usr/lib64/python2.7/site-packages/MDAnalysis/lib/c_distances_openmp.so python-MDAnalysis.x86_64: W: unused-direct-shlib-dependency /usr/lib64/python2.7/site-packages/MDAnalysis/lib/c_distances_openmp.so /lib64/libpthread.so.0 python-MDAnalysis.x86_64: W: no-soname /usr/lib64/python2.7/site-packages/MDAnalysis/lib/c_distances.so python-MDAnalysis.x86_64: W: unused-direct-shlib-dependency /usr/lib64/python2.7/site-packages/MDAnalysis/lib/c_distances.so /lib64/libpthread.so.0 python-MDAnalysis.x86_64: W: no-soname /usr/lib64/python2.7/site-packages/MDAnalysis/lib/qcprot.so python-MDAnalysis.x86_64: W: unused-direct-shlib-dependency /usr/lib64/python2.7/site-packages/MDAnalysis/lib/qcprot.so /lib64/libpthread.so.0 python-MDAnalysis.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/MDAnalysis/coordinates/xdrfile/_libxdrfile2.so 775 python-MDAnalysis.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/MDAnalysis/lib/_transformations.so 775 python-MDAnalysis.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/MDAnalysis/lib/c_distances_openmp.so 775 python-MDAnalysis.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/MDAnalysis/coordinates/_dcdmodule.so 775 python-MDAnalysis.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/MDAnalysis/coordinates/dcdtimeseries.so 775 python-MDAnalysis.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/MDAnalysis/lib/c_distances.so 775 python-MDAnalysis.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/MDAnalysis/lib/qcprot.so 775 3 packages and 0 specfiles checked; 8 errors, 12 warnings. Requires -------- python-MDAnalysis (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgomp.so.1()(64bit) libgomp.so.1(GOMP_4.0)(64bit) libgomp.so.1(OMP_1.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) netcdf4-python numpy python(abi) python-GridDataFormats python-biopython python-matplotlib python-networkx python-seaborn rtld(GNU_HASH) scipy python-MDAnalysis-debuginfo (rpmlib, GLIBC filtered): python-MDAnalysis-doc (rpmlib, GLIBC filtered): Provides -------- python-MDAnalysis: bundled(xdrfile) python-MDAnalysis python-MDAnalysis(x86-64) python-MDAnalysis-debuginfo: python-MDAnalysis-debuginfo python-MDAnalysis-debuginfo(x86-64) python-MDAnalysis-doc: python-MDAnalysis-doc Unversioned so-files -------------------- python-MDAnalysis: /usr/lib64/python2.7/site-packages/MDAnalysis/coordinates/_dcdmodule.so python-MDAnalysis: /usr/lib64/python2.7/site-packages/MDAnalysis/coordinates/dcdtimeseries.so python-MDAnalysis: /usr/lib64/python2.7/site-packages/MDAnalysis/coordinates/xdrfile/_libxdrfile2.so python-MDAnalysis: /usr/lib64/python2.7/site-packages/MDAnalysis/lib/_transformations.so python-MDAnalysis: /usr/lib64/python2.7/site-packages/MDAnalysis/lib/c_distances.so python-MDAnalysis: /usr/lib64/python2.7/site-packages/MDAnalysis/lib/c_distances_openmp.so python-MDAnalysis: /usr/lib64/python2.7/site-packages/MDAnalysis/lib/qcprot.so Source checksums ---------------- https://pypi.python.org/packages/source/M/MDAnalysis/MDAnalysis-0.13.0.tar.gz : CHECKSUM(SHA256) this package : bdf5a15842bd4e4635fcb60297978252c55c5828c9b7003d810c9e19a4fffbe6 CHECKSUM(SHA256) upstream package : bdf5a15842bd4e4635fcb60297978252c55c5828c9b7003d810c9e19a4fffbe6 https://pypi.python.org/packages/source/M/MDAnalysisTests/MDAnalysisTests-0.13.0.tar.gz : CHECKSUM(SHA256) this package : 852d5c24c018f093c3b4cdc5046df50ac48e157df94481299ff21687bacabab9 CHECKSUM(SHA256) upstream package : 852d5c24c018f093c3b4cdc5046df50ac48e157df94481299ff21687bacabab9 Generated by fedora-review 0.6.0 (7737a2a) last change: 2015-11-26 Command line :./try-fedora-review -m fedora-rawhide-x86_64 -b 1189015 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
