https://bugzilla.redhat.com/show_bug.cgi?id=1304632
--- Comment #2 from Michal Schmidt <[email protected]> --- > Group: System Environment/Libraries The Group: tag is unnecessary. (per http://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections) But it's harmless, so you can keep it if you want. > Url: https://www.openfabrics.org/ I see libmlx5 does not have anything like a home page of its own, so this Url is the best possible. Please consider adding a comment pointing to the libmlx5.git repository (unfortunately there is no standard RPM tag for that). I would find it useful. > %ifnarch ia64 %{sparc} %{arm} > BuildRequires: valgrind-devel > %endif valgrind is available on both armv7hl and aarch64. And Fedora no longer does any ia64 or sparc builds. So I think "BuildRequires: valgrind-devel" can be made unconditional. > ExcludeArch: s390 s390x Use of ExcludeArch needs an explanatory comment in the spec. > %package static Static libraries should only be included in exceptional circumstances. (http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries) Please explain why having the static library is necessary. > %files > %doc AUTHORS COPYING README Please use %license instead of %doc for the COPYING file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
