https://bugzilla.redhat.com/show_bug.cgi?id=1309707

Denis Fateyev <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Denis Fateyev <[email protected]> ---
Looks good now. Only some small things:

1) You can add "coreutils" to BR (`install` belongs to it);

2) Since bash is required, you can set common shebang "#!/bin/sh", getting rid
of "/usr/bin/env" RPM dep at the same time;

3) Since `mapping-rfc.txt` is now included, you can add
`openssl-rfc.mappping.html` to %doc.

Otherwise package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to