https://bugzilla.redhat.com/show_bug.cgi?id=1312408
--- Comment #2 from Jerry James <[email protected]> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > The description is unclear: is it classes for writing unit tests? Can you > reword the description so it unambiguous what the purpose of the package is. I have attempted to do so. > In check, use "nosetests-%{python3_version}", don't hardcode the version. > And nosetests-%{python2_version}" for the python 2 tests. Ah, I didn't understand that that was the python version. That would be a useful tip to put on the python packaging guidelines page, I think. > When you remove the shebang line, the file is modified, and there rule that > timestamps of unmodified files should be preserved does not apply anymore. > You can just use plain old "sed -i". Okay, done. > Would it work if you built python 2 and 3 versions from the same build > directory? Maybe, but I don't want to. I prefer to keep separate builds in separate directories so that there is no possibility of cross contamination. New URLs: Spec URL: https://jjames.fedorapeople.org/python-sphinx-testing/python-sphinx-testing.spec SRPM URL: https://jjames.fedorapeople.org/python-sphinx-testing/python-sphinx-testing-0.7.1-2.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
