https://bugzilla.redhat.com/show_bug.cgi?id=1315020



--- Comment #3 from Mukundan Ragavan <[email protected]> ---
(In reply to Jonathan Underwood from comment #2)
> Couple of quick comments:
> 
> 1/ Presumably these two deps of the main package:
> 
> Requires:     numpy
> Requires:     scipy
> 
> Should actually be deps of each of the python[2,3] subpackages
> (python3-numpy and python3-scipy in the py 3 case
> 

True! That's fixed now.

> 2/ Having that exact same long description 3 times in the spec file is an
> eyeful. Perhaps define a macro to store the text. Consider shortening the
> text too - that's a lot of detail. Ideally the descriptions for the py2 and
> py3 sub-packages would mention that they provide support for Python 2 and
> Python 3 respectively.

I was debating about this myself. I have just left this in the spec file now.

"nmrglue is a module for working with NMR data in Python. When used with the 
numpy, scipy, and matplotlib packages nmrglue provides a robust interpreted 
environment for processing, analyzing, and inspecting NMR data."

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to