https://bugzilla.redhat.com/show_bug.cgi?id=1311752
--- Comment #7 from Zbigniew Jędrzejewski-Szmek <[email protected]> --- The review does not depend on this, but the spec file is a bit iffy. It's something that would be nice to fix at some point. 1. Type=simple means that there's no synchronization wrt. to the daemon being ready to serve requests. So it's harder to write something that uses the daemon because it is necessary to poll for it to start. It would be much better to support Type=notify, or if that is not possible Type=forking. 2. /etc/default/* is a horrible "standard" that should not be propagated. Since you are introducing the package to Fedora with no prior installations, now is the best time to simply kill support for that file. I have to go now, I'll do the rest of the review later. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
