https://bugzilla.redhat.com/show_bug.cgi?id=1268369
Jun Aruga <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Jun Aruga <[email protected]> --- Let me review this. But if there are any other things to comment, please comment. * spec file - You should add your test suite in %check section. See https://fedoraproject.org/wiki/Packaging:Guidelines#Test_Suites > If the source code of the package provides a test suite, it should be executed in the %check section, whenever it is practical to do so. - rubygem-http_parser is using ruby_http_parser.so compiled by itself. But http_parser package exits in Fedora package. So, should use the package. See http://fedoraproject.org/wiki/Packaging:ReviewGuidelines > MUST: Packages must NOT bundle copies of system libraries * license ok after checking with licensecheck tool. * rpmlint - rpmlint shows below thing. but it looks no problem. rubygem-http_parser.rb.x86_64: E: zero-length /usr/lib64/gems/ruby/http_parser.rb-0.6.0/gem.build_complete - Other warnings looks ok. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
