https://bugzilla.redhat.com/show_bug.cgi?id=1317939
--- Comment #2 from Benji Wiebe <[email protected]> --- Thanks for taking the time to look at this... Description: See if you like the new description better. The acronyms are what most users would recognize, so I left them in, but added some more words to make it plainer for those who aren't familiar with it. Version: Using the format YYYYMMDDgitSHORTCOMMIT now. BuildRequires/Requires are now split out onto separate lines. What you said about diffability makes good sense. I wasn't aware of %make_build, fixed. Patch1 and Patch2 are both add-one-file patches, so I moved both to Source1 and Source2 respectively. For Systemd, I'm not sure I've got it right yet. I had been going off https://fedoraproject.org/wiki/Packaging:Systemd#Packaging but apparently that is out-of-date information? Switched to %license for the COPYING file. The default ownership of %{_datarootdir}/%{name} and %{_datarootdir}/%{name}/public_html looks correct to me. It show be owned by root:root and everyone should have read permissions but not write permissions. Also I removed the two Requires:, as they were unnecessary. Good ol' rpmlint. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
