https://bugzilla.redhat.com/show_bug.cgi?id=1213065
--- Comment #13 from jiri vanek <[email protected]> --- (In reply to Alex Kashchenko from comment #12) > Thanks for the review, on the comments: > > > There are sources of some "calc" even with manpage. Is it intentionally > > not-packed? > > Yes, it is a separate utility myc that is not built by default. It's code is > also built into the main hexer binary. I see. If you will ever pack it, I would recommend to prefix it to hexer-calc (And same wit manpage) But its completely up to you. if you don't mind, I will comaintaint this package with you and observe the changes you are doing for some time. > > > It seems that makefile is supporting setupable bindir and mandir. Maybe it > > is better to set them in make and make install rather then cp? > > "install" target depends on "all" target in that Makefile - so it is not > convenient to use it inside the "%install". As only two files are required > to be copied, current way looks more straightforward. np. > > > Have you tried arm32 build? > > Yes, armv7hl build works. thanx:) > > > One note, where I don't know how the world is standing - Have you > > considered moving .h files to devel subpackage? I guess there is no need to > > do it, unles syou really can use it as library. > > It looks like it is not intended to be used as a library. Sure. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
