https://bugzilla.redhat.com/show_bug.cgi?id=1197517
Raphael Groner <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Whiteboard| |Trivial --- Comment #2 from Raphael Groner <[email protected]> --- Some general advice in prior: - Description is quite long, can you shorten that? See also change_log.txt - Are you sure about license is GPLv3, but not GPLv3+ (mind the plus) that means "or any later version"? - Remove 'rm -rf %{buildroot}' from %install, it's obsolete. - Use a better name for the binary, elmon_x86_rhel52 looks bad. elmon may be enough for a proper name. Obviously, users won't install several multilib binaries in parallel, or what is the name suffix for? - As it's one source file only in the tarball, I would recommend to skip the makefile and use a call to cc directly inside the spec %build, you've already manual installation, so why use wrong looking makefile. - Add BuildRequires: gcc https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B#BuildRequires_and_Requires -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
