https://bugzilla.redhat.com/show_bug.cgi?id=1264703

Raphael Groner <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
            Summary|Review Request: syntastic   |Review Request: syntastic -
                   |                            |A vim plugins to check
                   |                            |syntax for programming
                   |                            |languages
              Flags|                            |needinfo?(bioinfornatics@gm
                   |                            |ail.com)



--- Comment #3 from Raphael Groner <[email protected]> ---
Some general advice in prior:

a. Upstream has official releases. You should package the latest. Why do you 
   want to use a git snapshot?
   https://github.com/scrooloose/syntastic/releases
-Version:        3.6.0
-URL:            https://github.com/scrooloose/syntastic
-Source0:        %{name}-%{alphatag}.tar.xz
+Version:        3.7.0
+URL:            https://github.com/scrooloose/%{name}
+Source0:        %{url}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.xz

b. Remove explicit (why?) BuildRequires:  glibc-common
c. You must use %license LICENCE

Please fix the above points, then I could do an official fedora-review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to