https://bugzilla.redhat.com/show_bug.cgi?id=1318873



--- Comment #3 from gil cattaneo <[email protected]> ---
Some problem must be solved before continue/strat with the review:

- disable/remove maven-shade-plugin, is not safe bundle system libraries
- scope system and systemPath are not supported instead open a bug for add
  maven poms or simply depmap for the required artifacts
  e.g.
  @ http://pkgs.fedoraproject.org/cgit/rpms/jhdf5.git/tree/jhdf5.spec#n178

  %mvn_file org.hdfgroup:jhdf5 jhdf5
  %mvn_artifact org.hdfgroup:jhdf5:%{version} lib/jhdf5.jar

  @ http://pkgs.fedoraproject.org/cgit/rpms/jhdf5.git/tree/jhdf5.spec#n194
  %mvn_file org.hdfgroup:jhdfobj jhdfobj
  %mvn_artifact org.hdfgroup:jhdfobj:%{version} lib/jhdfobj.jar

- remove
install -Dm0644 target/%{name}-%{version}.jar
%{buildroot}%{_javadir}/%{name}.jar
install -Dm0755 %{SOURCE1} %{buildroot}%{_bindir}/%{name}
install -Dm0644 pom.xml %{buildroot}%{_mavenpomdir}/%{name}.pom
 and use

 %files -f .mfiles
 %{_bindir}/%{name}
 %license LICENSE
 %doc README.rst README.html stim-params{,2}.{svg,png}

 %files javadoc -f .mfiles-javadoc
 %license LICENSE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to