https://bugzilla.redhat.com/show_bug.cgi?id=1319451



--- Comment #5 from Honggang LI <ho...@redhat.com> ---
(In reply to Michal Schmidt from comment #2)
> Issues
> ======
> The LICENSE file should be in the package and marked as %license.

Packaged it up.

> Must own the directory /usr/share/maven-poms/mbassador
> 

Done.

> Suggestions
> ===========
> Group tag is unnecessary.

Removed.

diff -up mbassador.spec.old mbassador.spec
--- mbassador.spec.old  2016-04-05 23:11:21.511068286 -0400
+++ mbassador.spec      2016-04-05 23:21:34.511230723 -0400
@@ -1,9 +1,8 @@
 Name:          mbassador
 Version:       1.2.4.1
-Release:       1%{?dist}
+Release:       2%{?dist}
 Summary:       An event bus aiming at ease of use and performance

-Group:         Development/Libraries
 License:       MIT
 URL:           https://github.com/bennidi/mbassador.git
 Source0:      
https://github.com/bennidi/%{name}/archive/%{name}-%{version}.tar.gz
@@ -31,7 +30,6 @@ performance github repository.

 %package javadoc
 Summary:       API Documentation for %{name}
-Group:         Documentation
 Requires:      %{name} = %{version}-%{release}

 %description javadoc
@@ -47,14 +45,21 @@ JavaDoc documentation for %{name}
 %mvn_install

 %files
+%license LICENSE
 %{_javadir}/%{name}
 %{_usr}/share/maven-metadata/%{name}.xml
+%dir %{_mavenpomdir}/%{name}
 %{_mavenpomdir}/%{name}/%{name}.pom

 %files javadoc
 %{_javadocdir}/%{name}

 %changelog
+* Tue Apr  5 2016 Honggang Li <ho...@redhat.com> - 1.2.4.1-2
+- Remove unnecessary Group tag.
+- Own all drectories and files created by it.
+- Package LICENSE file.
+
 * Sun Mar 27 2016 Honggang Li <ho...@redhat.com> - 1.2.4.1-1
 - Update to upstream version 1.2.4.1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

Reply via email to