https://bugzilla.redhat.com/show_bug.cgi?id=1202063
--- Comment #21 from Antti Järvinen <[email protected]> --- Spec URL: http://katiska.org/classified_ads/srpm/classified-ads.spec SRPM URL: http://katiska.org/classified_ads/srpm/classified-ads-0.10-1.fc25.src.rpm Ok Sirs, here is what is intended for 0.10 release. There is a new upstream release with additional features and also attempt to address problems related to packaging. Details below: > - suggestion: put BuildRequires each on a separate line, this makes it easier > to spot mistakes. Now done. > - suggestion: add empty lines before %description, before %changelog, before > %files. Now done. - suggestion: use "%make_install INSTALL_ROOT=%{buildroot}" for the make line (shorter is better). Not done, $DESTDIR is still required by makefile or translation files will end up in wrong location. ..partially due to stupidity in makefile generation but un-trivial to fix in qt environment. - suggestion: use '.*' instead of '.gz' for the man pages. This will avoid issues if the compression ever changes. Now done. - You should use %find_lang macro instead of explicitly listing files. See https://fedoraproject.org/wiki/PackagingDrafts/find_lang. Now done. - DISPLAY= classified-ads dumps core :( (Not a packaging issue, just pointing it out.) Now done. Reason for this not being done before was issues with wayland but there may be a workaround. The workaround is not tested with wayland so please report any issues. Rpmlint seems quiet. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] http://lists.fedoraproject.org/admin/lists/[email protected]
