https://bugzilla.redhat.com/show_bug.cgi?id=1311045
--- Comment #14 from Honggang LI <[email protected]> --- (In reply to Neil Horman from comment #8) > <NH> The spec file indicates this is GPL or BSD licensed, but the COPYING > file > in the source indicates GPLv2 fixed. > > [x]: License file installed when any subpackage combination is installed. > [!]: If the package is under multiple licenses, the licensing breakdown > must be documented in the spec. > <NH> see above Fixed too. > [!]: %config files are marked noreplace or the reason is justified. > <NH> Note: No (noreplace) in %config /etc/libibverbs.d/ocrdma.driver > It is unnecessary as it should be replaced. > [x]: Package contains desktop file if it is a GUI application. > [x]: Development files must be in a -devel package > <NH> Seems like -devel is missing header files The devel package had been renamed as static. So, it is no longer an issue. > [! : Package use %makeinstall only when make install DESTDIR=... doesn't > work. > Note: %makeinstall used in %install section > <NH> DESTDIR works fine, you should use that > Replace it with %{make_install}. > <NH> version 1.0.7 appears to have been released > Updated to latest 1.0.8. thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] http://lists.fedoraproject.org/admin/lists/[email protected]
