https://bugzilla.redhat.com/show_bug.cgi?id=1327828

Zbigniew Jędrzejewski-Szmek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #2 from Zbigniew Jędrzejewski-Szmek <[email protected]> ---
https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries
says:
"Fedora packages should make every effort to avoid having multiple, separate,
upstream projects bundled together in a single package."

Why do you package sources from three different tarballs, and two different
projects (numixproject, shimmerproject)?


cd Numix-%{commit2}
make install DESTDIR=%{buildroot}
cd ..
↓
%make_install -C Numix-%{commit2}

You can drop the Group tags
[https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections].


You should use the %license tag for the license file
[https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text].

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
http://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to