https://bugzilla.redhat.com/show_bug.cgi?id=1327994

Zbigniew Jędrzejewski-Szmek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <[email protected]> ---
Created attachment 1148257
  --> https://bugzilla.redhat.com/attachment.cgi?id=1148257&action=edit
tweaks to the spec file

I wanted to try the review of python-jupyter-client, so I needed this to build
:)

The fix for the missing module is simple enough (add PYTHONPATH).

I also modified the installation procedure to link jupyter → jupyter-2 →
jupyter-2.7, jupyter-3 → jupyter-3.5 (with cp one of those symlinks would be
real files instead)

Also %license.

Some more things I'd change:

I think the package should be renamed to python-jupyter-core. "use dashes in
preference to underscores."
[https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming].

Summary should not repeat the package name, and should not be a sentence. And
the %description could be extended to say what this package actually does.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
http://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to