https://bugzilla.redhat.com/show_bug.cgi?id=744416



--- Comment #12 from Robert Scheck <[email protected]> ---
(In reply to Mukundan Ragavan from comment #11)
> Just two questions. See below.

Aweseome, thank you very much for the time and efforts to do the review!

> - Large documentation must go in a -doc subpackage. Large could be size
>   (~1MB) or number of files.
>   Note: Documentation size is 3409920 bytes in 72 files.
>   See:
>   http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
> 
> 
> ---> Any reason not to create a -doc package?

Good point, didn't look to the size for a long time; investigating now.

> [!]: If the package is under multiple licenses, the licensing breakdown
>      must be documented in the spec.
> 
> ---> Please fix this. Should also include MIT.
> 
> License:      GPLv2+ and LGPLv2+

Maybe I'm overlooking something...but which files are MIT?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
http://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to