https://bugzilla.redhat.com/show_bug.cgi?id=1332999

Michael Cullen <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #4 from Michael Cullen <[email protected]> ---
*Unofficial comments - I too am waiting for a sponsor *

Minor, mostly personal choice point first: you don't need the "sum" global -
just include the summary in the header as usual and then use %{summary} where
you need it. Though having said that, the python sample spec file does it your
way. I just like keeping extra macros to a minimum.

The Group tag is not needed [1]

Ideally the description would be a little bit more than just the summary

rpmlint is clean, which is good

license looks fine


[1] https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
http://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to