https://bugzilla.redhat.com/show_bug.cgi?id=1326504



--- Comment #5 from Adam Huffman <[email protected]> ---

Thanks for taking a look, Dave. Sam and I had been e-mailing privately about
this and updating on Github, but it's better handled here.

(In reply to Dave Love from comment #4)
> In the meantime, I looked at building this for an updated samtools and
> noticed these:
> 
> Install LICENSE, and probably NEWS
> 
> Add a proper %changelog
> 
> Remove the explicit Provides
> 
> Source URL is wrong
> 
> Run "chmod 755" on the library for correct debuginfo packaging
> 
> Run tests (in a %check section)
> 
> Is there a good reason not to include bzip2 and/or lzma support?  Maybe
> comment if so.
> 
> DESTDIR=... is redundant with %make_install

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
http://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to