https://bugzilla.redhat.com/show_bug.cgi?id=1332344
Mukundan Ragavan <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #11 from Mukundan Ragavan <[email protected]> --- (In reply to Michael Cullen from comment #10) > I only see one issue - the desktop database one. The other thing on the > issues list actually goes against the guidance in > https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B > > did I miss one? That's right. There was only one (apparently, I cannot count! :)). gcc-c++ is not an issue as I have mentioned. From my comment - " - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ---> This is fine. " > > > Spec URL: https://cullen-online.com/rpm-review/phototonic.spec > SRPM URL: > https://cullen-online.com/rpm-review/phototonic-1.7.20-2.fc24.src.rpm I see that everything is fixed. Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] http://lists.fedoraproject.org/admin/lists/[email protected]
