https://bugzilla.redhat.com/show_bug.cgi?id=1335965
Miro Hrončok <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Flags| |needinfo?([email protected] | |om) --- Comment #1 from Miro Hrončok <[email protected]> --- First eyes only review of the spec: > # A header-only library has no debuginfo > %global debug_package %{nil} Isn't header ony library noarch? That would also mean debuginfo will not be generated. > License: MIT and CC-BY-SA Please describe in comment what parts have what specific license. I assume CC-BY-SA is documentation, but it should be written in comment anyway. Oh, it's subpackages level split, so maybe just say something like: # licenses differ for subpackages > URL: http://py3c.readthedocs.io/en/latest/guide.html I'd suggest to use plain simple http://py3c.readthedocs.io/ > Source0: > https://github.com/encukou/py3c/archive/v0.5.tar.gz#/py3c-0.5.tar.gz Don't hardcode the version number here, but use %{version} instead. > BuildRequires: python-devel Should be python2-devel > # Do not require python2-devel, because some projects can drop Python 2 > support > # but still use the compat macros. Maybe use Suggests here. > Provides: %{name}-static = %{version}-%{release} This might need some arch specific tweaks, but if you do it noarch, you'll avoid that. > make ... You should uses parallel make %{?_smp_mflags} macro, but in case you know there is nothing to be parallel, I guess you can omit that. I guess that in %check it can run in parallel, but maybe the readability of the output would be bad, give it a try. > %{_includedir}/py3c/*.h You should own the directory, easiest way is to do this instead: %{_includedir}/py3c But if you want to doublecheck that only .h files are in there, you can do: %dir %{_includedir}/py3c %{_includedir}/py3c/*.h Also: The docs files -- might be easier not to copy them around, but add them directly in %doc instead. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] http://lists.fedoraproject.org/admin/lists/[email protected]
