https://bugzilla.redhat.com/show_bug.cgi?id=1337120
--- Comment #5 from jiri vanek <[email protected]> --- Hi Patrik! First few nits: There is license in: https://github.com/gyazo/Gyazo-for-Linux/blob/master/debian/copyright Please pack it as %license You should replace ahrdocded paths to ruby by this macro %{ruby_vendorlibdir} Also you should pack the gyazo.rb to subfolder /gyazo/gyazo.rb. so: %{ruby_vendorlibdir}/gyazo/gyazo.rb Also there is macro for /usr/share, and Ithink also for /usr/share/applications/ itself. You have missing empty line in %chagelog: - Added and Patched desktopfile xxxx Tehre xxxx * Mon Jul 13 2015 Yosuke Tamura <[email protected]> Also you may note to changelog that you used this spec file as template. Please put the requires on separate lines. Also there i error -the specfile you provided on google-drive is not the same as the one in SRPM. The one in srpm is better :) You should add man page and mention the config file it is using (as it is the only existing setup for the tool (eg switch jpg x gif or so...) Otherwise the pkg looks really good. Looking forward to have it in! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] http://lists.fedoraproject.org/admin/lists/[email protected]
