https://bugzilla.redhat.com/show_bug.cgi?id=1336872

Remi Collet <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+



--- Comment #5 from Remi Collet <[email protected]> ---
Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

=> OK, package design for symfony 2.8

[x]: Package does not own files or directories owned by other packages.
    => Ok (as dropped from synfony 2.8)

[~]: Requires correct, justified where necessary.
    Instead of 
        Requires:      php-composer(symfony/security-core) >=
%{symfony_min_ver}
        Conflicts:     php-symfony-security < 2.8.0
    Could be simpler to (keep 2.7 for the BR)
        Requires:      php-composer(symfony/security-core) >= 2.8

[x]: Latest version is packaged.
    => in the 2.8 branch

[x]: %check is present and all tests pass.
    PHP 5: ok
    PHP 7: ok


No Blocker, so the package conform with Fedora Guidelines.

=== APPROVED ===

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
http://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to