https://bugzilla.redhat.com/show_bug.cgi?id=1338339
Bug ID: 1338339
Summary: Review Request: openrave - Open Robotics Automation
Virtual Environment
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
CC: [email protected]
Spec URL: https://thofmann.fedorapeople.org/openrave.spec
SRPM URL:
https://thofmann.fedorapeople.org/openrave-0.9.0-11.20160519git2baf4e3.fc23.src.rpm
Description:
OpenRAVE is targeted for real-world autonomous robot applications, and
includes a seamless integration of 3-D simulation, visualization, planning,
scripting and control.
Fedora Account System Username: thofmann
koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14208789
There are two bundled libraries. Both libraries are dead upstream and
maintained within the openRAVE project. According to the package guidelines
[1], Provides have been added for both libraries.
rpmlint:
========
python2-openrave.x86_64: W: no-documentation
openrave-octave.x86_64: W: no-documentation
openrave-models.noarch: W: no-documentation
openrave-devel.x86_64: W: no-documentation
openrave.x86_64: W: no-documentation
--> documentation is in separate doc package
openrave-devel.x86_64: W: no-manual-page-for-binary openrave-config
openrave-devel.x86_64: W: no-manual-page-for-binary openrave-createplugin.py
python2-openrave.x86_64: W: no-manual-page-for-binary openrave.py
python2-openrave.x86_64: W: no-manual-page-for-binary openrave-robot.py
openrave.x86_64: W: no-manual-page-for-binary openrave
--> no manpages provided by upstream
openrave-devel.x86_64: W: only-non-binary-in-usr-lib
--> devel packages contains symlinks to actual libs
python2-openrave.x86_64: E: non-executable-script
/usr/lib64/python2.7/site-packages/openravepy/_openravepy_/ikfast_generator_cpp.py
644 /usr/bin/env
python2-openrave.x86_64: E: non-executable-script
/usr/lib64/python2.7/site-packages/openravepy/_openravepy_/ikfast_generator_cpp_sympy0_6.py
644 /usr/bin/env
openrave.x86_64: E: non-executable-script /usr/share/openrave/openrave.bash 644
/bin/bash
--> not intended to be executable scripts, see [2] for a short discussion
python2-openrave.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.7/site-packages/openravepy/_openravepy_/ikfast.h
--> part of the bindings
openrave.x86_64: W: shared-lib-calls-exit /usr/lib64/libopenrave-core.so.0.9.0
exit@GLIBC_2.2.5
--> reported upstream [3]
There is one patch [4] which is necessary because qhull paths changed in
rawhide. It doesn't make sense to send that patch upstream because it is
specific to Fedora (although a more general solution would be possible).
All other changes have been merged upstream.
Note that there has been a review request before (bz #674008). This review
request is based on the old one.
A review would be highly appreciated!
[1]
https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries
[2] https://github.com/rdiankov/openrave/pull/353
[3] https://github.com/rdiankov/openrave/issues/355
[4] https://thofmann.fedorapeople.org/openrave.qhull.patch
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
http://lists.fedoraproject.org/admin/lists/[email protected]
