https://bugzilla.redhat.com/show_bug.cgi?id=1339158
Ben Rosser <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #1 from Ben Rosser <[email protected]> --- As I said on 1332434, I'm happy to review this. I'll post a full review over the next few days, but for now, some comments (along with rpmlint output): pioneer.x86_64: W: name-repeated-in-summary C Pioneer pioneer.x86_64: W: no-documentation pioneer.x86_64: W: no-manual-page-for-binary modelcompiler pioneer.x86_64: W: no-manual-page-for-binary pioneer pioneer.x86_64: W: desktopfile-without-binary /usr/share/applications/pioneer.desktop env Maybe "A game of lonely space adventure" would be a better summary? That seems to be their tagline on github and on http://pioneerspacesim.net/. pioneer.src: W: name-repeated-in-summary C Pioneer pioneer.src: W: patch-not-applied Patch0: %{name}-fix_lua_header.patch This patch not being applied is because, as noted in the spec, the version of Lua in Fedora is too new to work with the bundled one in Pioneer. But, as per the new bundling policy, I think you should publicly contact Pioneer upstream about this? fedora-review does not like that the following directories are unowned: /usr/share/icons/pioneer /usr/share/icons/hicolor/40x40 /usr/share/icons/hicolor/40x40/apps At least the former should be owned by this package. It looks like Pioneer provides functionality for building Doxygen and Lua documentation as per https://github.com/pioneerspacesim/pioneer/blob/master/COMPILING.txt? This should probably be built and put in a pioneer-doc subpackage. Everything else looks good to me thus far! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://lists.fedoraproject.org/admin/lists/[email protected]
