https://bugzilla.redhat.com/show_bug.cgi?id=1344261
Raphael Groner <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Depends On| |1344294 --- Comment #3 from Raphael Groner <[email protected]> --- Can you put both packages warsow (this bug) and warsaw-data (bug #1344294) in one spec file? warsaw-data could be a subpackage and is not much useful for its own alone. We could handle all in one single review. Are you interested in a review swap? Maybe with bug #1344115. > %global warsow_libdir %{_prefix}/lib/warsow … > # Filter private libraries from provides > %global __provides_exclude_from ^%{warsow_libdir}/.*\\.so$ … > # Install private libraries to a private directory > install -d $RPM_BUILD_ROOT%{warsow_libdir}/libs > install -m 755 libs/*.so $RPM_BUILD_ROOT%{warsow_libdir}/libs/ … %files %{warsow_libdir}/ This does not look right to me. Please explain why this private(?) folder must be used. You should use %{_libdir}/%{name} instead to also honor 64 bits with /usr/lib64/warsaw. > BuildRequires: /usr/bin/convert > BuildRequires: /usr/bin/desktop-file-install > BuildRequires: /usr/bin/dos2unix Better is to use concrete package names: BuildRequires: ImageMagick BuildRequires: desktop-file-utils BuildRequires: dos2unix You can verify with dnf whatprovides. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1344294 [Bug 1344294] Review Request: warsow-data - Game data for Warsow -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://lists.fedoraproject.org/admin/lists/[email protected]
