https://bugzilla.redhat.com/show_bug.cgi?id=1350029

Igor Gnatenko <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #15 from Igor Gnatenko <[email protected]> ---
Unfortunately it's not yet good package.

> %defattr(-,root,root,-)
MUST be dropped

> %clean
> rm -rf %{buildroot}
MUST be dropped

> make %{?_smp_mflags}
COULD be replaced iwth %make_build

> make DESTDIR=%{buildroot} install
COULD be replace with %make_install

> %setup -q -n %{name}-%{version}
COULD be changed to %setup -q or to %autosetup

> BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
MUST be dropped

> Group: System Environment/Libraries
> Group: System Environment/Libraries
COULD be dropped

> %package devel-static
It's actually not devel-static, but just static. Please adjust.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to