https://bugzilla.redhat.com/show_bug.cgi?id=1355592

Igor Gnatenko <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?



--- Comment #1 from Igor Gnatenko <[email protected]> ---
> Source0:        %{name}-%{version}.tar.gz
Must be full URL, something like:
https://github.com/libvmi/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz

> BuildRequires:  glib2-devel >= 2.16 check-devel >= 0.9.4
BuildRequires: pkgconfig(glib-2.0)
BuildRequires: pkgconfig(check)

> rm -rf $RPM_BUILD_ROOT
not needed

> find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'
find %{buildroot}%{_libdir} -name '*.la' -delete -print

> rm -f ${RPM_BUILD_ROOT}/%{_bindir}/*
rm -vf %{buildroot}{_bindir}/*

> # Parallel make fails.
there should be link to upstream issue

> %{_includedir}/libvmi
%{_includedir}/%{name}/

> BuildRequires:  bison flex xen-devel fuse-devel
also guessing there are missing BuildRequires: autoconf automake libtool
or something like to for ./autogen.sh

* Missing BuildRequires: gcc


Once this will be fixed, I will do full review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to