https://bugzilla.redhat.com/show_bug.cgi?id=1356048



--- Comment #2 from Jaroslav Škarvada <[email protected]> ---
(In reply to Antonio Trande from comment #1)
Thanks for taking the review.

> - Please, leave a comment about the patch-
This is fedora distro specific patch updating paths and modularizing the
package (because AFAIK the package cannot be installed into fedora
non-modularized). I thought that the -fedora suffix is enough, but no problem,
I added short description.

I am also planning to generalize it and propose upstream.

> 
> - Create an appdata file.
Sorry, what do you mean?

> 
> - Installation instruction says:
> 
> >Newer kernels have a DVB driver included which won't work with the RTLSDR 
> >driver
> 
> Kernel module 'dvb_usb_rtl28xxu' has to be balcklisted, and this software
> needs rtl-sdr to work. 'rtl-sdr' is required. Right ?

This is frontend to rtl-sdr which IIRC should handle the kernel DVB-T driver
conflict for some time. It should unbind the driver and rebind later. So I
think the blacklist instructions are obsoleted (but you can still do it).

Regarding rtl-sdr requirement, the package requires python2-pyrtlsdr, which is
python binding to rtl-sdr and it requires rtl-sdr, so the deps should be OK.
But maybe there are some missing deps, I havent tested the package in chroot
(to bo honest I haven't tested the functionality yet, because I don't have here
the required HW, I will test the functionality later today).

Due to the minor change I updated the package silently without release bump,
sorry about it :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to