https://bugzilla.redhat.com/show_bug.cgi?id=1357483
Igor Gnatenko <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Igor Gnatenko <[email protected]> --- Few quick nitpicks: * why don't you build released 5 days ago 1.10? * Use cmake()-style dependencies where available, e.g. for Qt5: > find_package(Qt5Widgets REQUIRED) > find_package(Qt5LinguistTools REQUIRED) > find_package(Qt5Quick REQUIRED) BR: cmake(Qt5Widgets) ... * Add %check with desktop-file-validate * mark %{_mandir}/man1/%{name}.1* as %doc * Would be great to add g729 and gsm support if possible * Missing BuildRequires: gcc-c++ Otherwise from first glance looks pretty clean spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://lists.fedoraproject.org/admin/lists/[email protected]
